Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add additional tests for undefined platform minification behavior. #27515

Merged
merged 2 commits into from Mar 8, 2024
Merged

chore: Add additional tests for undefined platform minification behavior. #27515

merged 2 commits into from Mar 8, 2024

Conversation

EvanBacon
Copy link
Contributor

Why

  • Metro's platform minification plugin has undefined behavior where the Platform module doesn't need to come from the react-native import, this inadvertently resolves the need to add support for expo-modules-core.
  • I'll add a follow up PR to fork the Metro plugin and remove the many additional passes used to support haste. Will also fix the extra case I found where .native is left as-is even when bundling for web.

Test Plan

  • Added tests only

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 8, 2024
@EvanBacon @expo-bot
Update packages/babel-preset-expo/CHANGELOG.md
f234d61 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 8, 2024
@EvanBacon EvanBacon merged commit 4d9c14e into main Mar 8, 2024
6 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/babel/add-extra-tests branch March 8, 2024 19:04
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvatne brentvatne Awaiting requested review from brentvatne brentvatne is a code owner

@ide ide Awaiting requested review from ide ide is a code owner

Assignees
No one assigned
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @brentvatne @expo-bot