Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-dev-launcher] Remove debug settings for EAS Updates extension #27603

Merged
merged 2 commits into from Mar 12, 2024

Conversation

wschurman
Copy link
Member

Why

This reverts #17842. Updating the URL or runtime version is considered dangerous as it could lead to incompatible updates being launched. While we may want to allow this in the future (or just allow browsing all updates, even incompatible ones), this treatment is causing confusion.

How

Revert most of the PR manually.

Test Plan

tsc

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 12, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Mar 12, 2024

The Pull Request introduced fingerprint changes against the base commit: 5a4eb49

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-dev-launcher",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "d45ad3514f0628fcdeb0eef24fde86ab9ad10cf4"
  }
]

Generated by PR labeler 🤖

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 12, 2024
@wschurman wschurman merged commit 09d4ce2 into main Mar 12, 2024
14 of 15 checks passed
@wschurman wschurman deleted the @wschurman/update-dev-launcher branch March 12, 2024 23:13
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants