Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-go] Fix bundling error for home #27612

Merged
merged 1 commit into from Mar 13, 2024
Merged

[expo-go] Fix bundling error for home #27612

merged 1 commit into from Mar 13, 2024

Conversation

wschurman
Copy link
Member

Why

Was seeing this error:

ERROR  Error: Cannot find native module 'ExpoAsset', js engine: hermes
 ERROR  Invariant Violation: "main" has not been registered.

This fixes it by putting ExpoAsset in the modules for home.

How

Add to the lists.

Test Plan

yarn start in apps/expo-go
Build on android studio, see it now works and bundles successfully.

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Mar 12, 2024
@brentvatne brentvatne requested a review from aleqsio March 13, 2024 01:09
@wschurman wschurman merged commit ee5a722 into main Mar 13, 2024
14 checks passed
@wschurman wschurman deleted the @wschurman/fix-home-wat branch March 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvatne brentvatne brentvatne approved these changes

@tsapeta tsapeta tsapeta approved these changes

@lukmccall lukmccall Awaiting requested review from lukmccall

@aleqsio aleqsio Awaiting requested review from aleqsio

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wschurman @brentvatne @tsapeta @expo-bot