fix(expo-router)!: compile as ESM #27638
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We changed the compilation to cjs to support importing manifest code in the CLI without needing to bundle, but as a result, all of react-native-web is pulled in to web projects. This PR changes the bundle format back to esm, and adds a cjs build step to the prepare script which can be used in CLI to access the manifest functions. The change results in decent bundle size savings:
950kb -> 880kb
in static-rendering e2e test.We'll need a follow up PR to do something similar to expo/metro-runtime so we aren't pulling in everything in development too.
Test Plan
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).