[ios][camera] Fix legacy camera getAvailablePictureSizes #27642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: 4844826 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-camera/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "9f3f091e46c30e63842b035fb47205315f903062"
}
]Generated by PR labeler 🤖 |
expo-bot
added
bot: passed checks
tsapeta
approved these changes
Mar 13, 2024
| @@ -201,7 +201,9 @@ public final class CameraViewModule: Module { | |||
|
|
|||
| AsyncFunction("getAvailablePictureSizes") { (_: String?, _: Int) in | |||
| // Argument types must be compatible with Android which receives the ratio and view tag. | |||
| return pictureSizesDict.keys | |||
| return pictureSizesDict.map { k, _ in | |||
There was a problem hiding this comment.
That's why we need more tests. It seems pretty easy to detect.
There was a problem hiding this comment.
Definitely. Not sure how that got through for so long
brentvatne
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes an issue reported by @kbrandwijk, where the
pictureSizewas not being setHow
The problem was
getAvailablePictureSizeswas returningpictureSizesDict.keyswhich does not return an array ofStringbut an array ofKeystructs. This would not get correctly parsed so would result in an empty array being sent back to JS.Test Plan
Bare-expo. The array is now correctly sent back and using the
pictureSizeprop works correctly.