[tools] Publishing canary templates in the publish script #27655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
force-pushed
the
@tsapeta/tools/publishing-canary-templates
branch
from
4e83d2c
to
022186a
Compare
tsapeta
force-pushed
the
@tsapeta/tools/publishing-canary-templates
branch
from
022186a
to
ab700ef
Compare
Kudo
approved these changes
Mar 14, 2024
brentvatne
reviewed
Mar 14, 2024
|
|
||
| // Publish the project template with a `canary` tag. | ||
| await publishPackageAsync(template.path, { | ||
| tagName: 'canary', |
There was a problem hiding this comment.
can we also add the sdk branch tag? so for sdk 51 canary, sdk-51
There was a problem hiding this comment.
Sure, we can! But I noticed there is an issue with how we version the expo package in canary releases – it's released as 50.0.0-canary-* instead of 51 😞 So, I would fix that first so we don't accidentally override sdk-50 tag.
There was a problem hiding this comment.
:X yeah we should definitely bump that to 51!
brentvatne
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
et publish --canaryis only publishing packages from thepackagesfolder, but it would be nice to also publish project templates that use the canary version of our packages.How
et update-project-templatestoProjectTemplatesutils, but left the command unchanged so I don't break it. In the future I think it would be good to mergeet update-project-templatesandet publish-project-templatesinto the non-canary flow ofet publishas well.Test Plan
et publish --canary --drypassed and confirmed whether changes in thetemplatesfolder (version bumps) are correct.