chore(cli): fix fast resolver #27686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
marklawlor
pushed a commit
that referenced
this pull request
Mar 18, 2024
# Why There was an issue where we attempted to match against the resolution error in order to continue resolving, but the custom error didn't match our matcher function. Now we should be able to use fast resolver in most apps. I've also switched the fs-extra methods over to fs which saves about 300ms in an app with 900 modules. # Test Plan - Tested manually. - Tests should keep working. - Added new tests for fragile check. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There was an issue where we attempted to match against the resolution error in order to continue resolving, but the custom error didn't match our matcher function. Now we should be able to use fast resolver in most apps.
I've also switched the fs-extra methods over to fs which saves about 300ms in an app with 900 modules.
Test Plan