[patch-project] Set CLI to executable on build for consistency with yarn in root #27687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unning yarn from root
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
marklawlor
pushed a commit
that referenced
this pull request
Mar 18, 2024
…arn in root (#27687) # Why - I noticed that the working tree was dirty when trying to run this job: https://github.com/expo/expo/actions/runs/8287945362/job/22681450966 - I saw when I ran `yarn` locally in the root of the repo (by chance, I happened to do it with a clean slate / no node_modules) it modified build/cli/index.js to add +x to mode. - I figured this would be fine to commit and solve all of our problems. But then check-packages failed: https://github.com/expo/expo/actions/runs/8289007758/job/22684616383 So: ### 1. after running yarn clean && yarn build in patch-project ``` ls -l build/cli/index.js -rw-r--r--@ 1 brent staff 4002 14 Mar 17:49 build/cli/index.js ``` ### 2. after running yarn from root (with a clean node_modules): ``` ls -l build/cli/index.js -rwxr-xr-x@ 1 brent staff 4002 14 Mar 17:49 build/cli/index.js ``` I believe this happens because `yarn` will link all workspace `bin`s and ensure they are executable. When we use `expo-module clean` we delete the build directory and re-generate it, re-creating it without executable mode. This is usually fine because in other pkgs we don't keep the bin inside of src, but in this case.. # How Add `chmod +x` in build script # Test Plan - patch-package and iOS Client - EAS workflows should both work. ([confirmed iOS client here](https://github.com/expo/expo/actions/runs/8289875387/job/22687033418)) - The two scenarios I shared in the "Why" section both produce the same results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
yarnlocally in the root of the repo (by chance, I happened to do it with a clean slate / no node_modules) it modified build/cli/index.js to add +x to mode.So:
1. after running yarn clean && yarn build in patch-project
2. after running yarn from root (with a clean node_modules):
I believe this happens because
yarnwill link all workspacebins and ensure they are executable. When we useexpo-module cleanwe delete the build directory and re-generate it, re-creating it without executable mode. This is usually fine because in other pkgs we don't keep the bin inside of src, but in this case..How
Add
chmod +xin build scriptTest Plan