Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(create-expo): configure pnpm and yarn berry when creating a new project #27699

Merged
merged 4 commits into from Mar 18, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Mar 15, 2024

Why

This should help users getting started easily when using pnpm or yarn berry.

How

I took a few considerations into account:

  • Do NOT change existing projects, just like we don't assert/fix gradle or cocoapods config
  • Only configure the package manager once, when creating a new project
  • Use the package manager itself to configure the project

Test Plan

These commands should now start the project, without problems or additional modifications.

  • $ pnpm create expo ./ --template tabs && pnpm expo start
    image
  • $ yarn create expo ./ --template tabs && yarn expo start
    Make sure you use yarn 2, 3, or 4. Yarn v1 won't configure anything and should work as expected.
    image

Checklist

@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 15, 2024
@byCedric byCedric merged commit 1090d14 into main Mar 18, 2024
11 checks passed
@byCedric byCedric deleted the @bycedric/create-expo/configure-pnpm-yarn-berry branch March 18, 2024 11:13
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants