[expo] support DevToolsPluginClient websocket multiplexing on expo web #27702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
tsapeta
approved these changes
Mar 15, 2024
Kudo
added a commit
that referenced
this pull request
Mar 19, 2024
#27702) if an expo web app contain multiple devtool plugins, we will create multiple websocket connection on web. - move the connection multiplexer from `DevToolsPluginClientImplApp` to base `DevToolsPluginClient` - the multiplexer relies on static variables. however, the unit tests are running in single process. this pr introduces a `WebSocketBackingStore` for test to specify their backing store. for normal use case, the default backing store is a static variable. (cherry picked from commit a8b2184)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
if an expo web app contain multiple devtool plugins, we will create multiple websocket connection on web.
How
DevToolsPluginClientImplAppto baseDevToolsPluginClientWebSocketBackingStorefor test to specify their backing store. for normal use case, the default backing store is a static variable.Test Plan
refine unit test and the tests passed
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).