fix(blur): Migrate web to a function component and fix reanimated errors #27721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to [`setNativeProps` being removed](necolas/react-native-web@e68c327)
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
tsapeta
approved these changes
Mar 17, 2024
marklawlor
pushed a commit
that referenced
this pull request
Mar 18, 2024
…ors (#27721) # Why - [`setNativeProps` was removed](necolas/react-native-web@e68c327) so we need to set the style props directly. This can be reproduced by opening NCL and going to the blur route. - Tested the change in both safari and chrome. - This PR also drops support for older browsers in favor of the unsupported style warning. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
setNativePropswas removed so we need to set the style props directly. This can be reproduced by opening NCL and going to the blur route.