[router] include ctx-shared.js in package files #27741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where typed routes would fail to generate
expo-bot
added
bot: passed checks
chriszs
changed the title
chriszs
changed the title
chriszs
changed the title
|
@marklawlor is addressing this in #27690. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes the failure documented in #27740 wherein typed route generation failed to find an import called
ctx-sharedin the Expo Router canary package.How
Includes the
ctx-shared.jsfile used by typed route generation in the expo-router package files by adding it to the explicit list of included files inpackage.json.Test Plan
To test I started with my minimal reproduction (in which
npm startfails), downloaded ctx-shared.js, moved it intonode_modules/expo-router/and, added an empty/appdirectory to satisfy an unrelated failure, then rannpm startagain (successfully). Test process demonstrated with patch-package here.