[router] fix relative navigation on hoisted routes #27778
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix #27753
How
This
isIndexPath
function was not taking in account hoisted index routes that may not have theparam
structureTake the following structure.
Because there are no route params or nested
_layout
, all routes are hoisted to the root_layout
. The existing logic for only checking forroute.params
is insufficient as it will not exist. Additionally we cannot check forname: 'index'
as hoisted routes have complex names.Test Plan
I think our existing tests are fine, just added one for this scenario
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).