Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metro-config): disable require rename #27853

Closed

Conversation

EvanBacon
Copy link
Contributor

Why

How

  • Fork the js file wrapping for converting modules to iife, and add an extra option to disable converting require to _$$_REQUIRE. This legacy behavior can be re-enabled by adding EXPO_METRO_RENAME_REQUIRES=1.

Test Plan

  • Tests will continue working, we may want to add a smaller test.

Checklist

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 25, 2024
@EvanBacon
Copy link
Contributor Author

Closing as this was landed upstream in facebook/metro@7250388

@EvanBacon EvanBacon closed this Apr 8, 2024
@EvanBacon EvanBacon deleted the @evanbacon/metro-config/pull-in-require-rename branch April 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants