New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo-video] Add expo-video
docs page
#27854
Conversation
📘 Your docs preview website is ready! |
883cf5d
to
653c23e
Compare
Few things to address:
|
2e96888
to
3c84e81
Compare
3c84e81
to
8c59b87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! 👍
As discussed offline, we will be working further to improve those docs in near future, but it's definitely a great start!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you adding this doc and for incorporating those changes
Why
Expo-video is missing a docs page.
ENG-11349
How
Renamed the
video.mdx
tovideo-av.mdx
and assignedvideo.mdx
asexpo-video
docs page. We should consider doing this the other way around (adding a suffix toexpo-video
file). Current way might create issues with linking to the docs, eg. if someone wants to redirect people to the latestexpo-av
video docs so they would link tohttps://docs.expo.dev/versions/latest/sdk/video/
, but the users will be redirected toexpo-video
docs after SDK 51. I kept it this way in case we believe people should be redirected toexpo-video
anyways. Let me know what you think about it :)Created a simple example for
expo-video
(similar to theexpo-av
example), which showcases how to use player properties and events.Test Plan
Tested by running the docs locally