Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metro-config)!: remove exotic transformer #27855

Merged
merged 3 commits into from Mar 25, 2024
Merged

chore(metro-config)!: remove exotic transformer #27855

merged 3 commits into from Mar 25, 2024

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Mar 25, 2024 •
edited

Why

  • We deprecated this feature in SDK 50 and now we'll drop all the source related to it.
  • We also pull out the cache key part for babel-preset-fbjs since this is no longer used in metro.
  • This PR no longer exports a getCacheKey from the babel transformer since metro checks the file contents already.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 25, 2024
EvanBacon and others added 2 commits March 25, 2024 14:00
@EvanBacon
drop unused cache key
a536bf7
@EvanBacon @expo-bot
Update packages/@expo/metro-config/CHANGELOG.md
9d3fa1c 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 25, 2024
@EvanBacon EvanBacon merged commit 47f2028 into main Mar 25, 2024
19 of 20 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/metro-config/fully-drop-exotic branch March 25, 2024 20:53
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byCedric byCedric Awaiting requested review from byCedric byCedric is a code owner

@marklawlor marklawlor Awaiting requested review from marklawlor marklawlor is a code owner

Assignees
No one assigned
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @brentvatne @expo-bot