chore: relax forbidden react server API errors #27878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
changed the title
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
ide
reviewed
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In RSC, components can be shared between server and client, the client components may contain react hooks which will run on the client but shouldn't run on the server. This PR reduces the errors to only throw when APIs are used and not when they're simply imported. The import errors still run when importing
ComponentorPureComponent.To fully support shared components, we'll need a follow up PR to "optimize" server components. This should collapse unused hooks so that they don't run, and therefore don't trigger the static error pass. This optimization pass is a bit tricky since we have old babel passes that obfuscate the expected syntax, ref facebook/react-native#43662
Test Plan