Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(babel): simplify rsc injection code #27879

Merged
merged 4 commits into from Mar 28, 2024

Conversation

EvanBacon
Copy link
Contributor

Why

The injection code is a bit of a hack to workaround Metro, this PR simplifies the transform so we can work on improving it in the future.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 26, 2024
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 26, 2024
Copy link
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some small changes

@EvanBacon EvanBacon merged commit 6245632 into main Mar 28, 2024
7 of 8 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/babe/simplify-rsc-injection branch March 28, 2024 01:21
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants