New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] add information link to web platform metro error #27884
Open
kbrandwijk
wants to merge
9
commits into
main
Choose a base branch
from
kbrandwijk/eng-10222-make-export-web-error-actionably
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[cli] add information link to web platform metro error #27884
kbrandwijk
wants to merge
9
commits into
main
from
kbrandwijk/eng-10222-make-export-web-error-actionably
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
reviewed
Mar 27, 2024
brentvatne
reviewed
Apr 2, 2024
Co-authored-by: Brent Vatne <brentvatne@gmail.com>
brentvatne
approved these changes
Apr 2, 2024
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
See ENG-10222. The docs provide additional information for adding web support to metro. We can add a link to this to the error message for the 'web' platform to provide better guidance to the user.
How
Only for web, appended a more information link to the existing error message.
Test Plan
Export for web without adding the web bundler directive to app.json, observe the error.
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).