Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] add information link to web platform metro error #27884

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

kbrandwijk
Copy link
Member

Why

See ENG-10222. The docs provide additional information for adding web support to metro. We can add a link to this to the error message for the 'web' platform to provide better guidance to the user.

How

Only for web, appended a more information link to the existing error message.

Test Plan

Export for web without adding the web bundler directive to app.json, observe the error.

Checklist

Copy link

linear bot commented Mar 27, 2024

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 27, 2024
Co-authored-by: Brent Vatne <brentvatne@gmail.com>
@expo-bot
Copy link
Collaborator

expo-bot commented Apr 9, 2024

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against eca1c1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants