Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] upgrade to cache v4 #27898

Conversation

kbrandwijk
Copy link
Member

@kbrandwijk kbrandwijk commented Mar 27, 2024

Why

actions/cache@v3 runs on Node 16 which is no longer supported. Upgrading to v4 has no breaking changes and includes only running on Node 20 now, so the upgrade should be painless.

How

Replaced all instances of cache@v3 by cache@v4

Test Plan

Not sure how to test this properly. Maybe by seeing the actions on this PR branch run without the warning message? Although it seems that it doesn't pick up the change.

Checklist

@kbrandwijk kbrandwijk requested a review from tsapeta March 27, 2024 17:21
Copy link

linear bot commented Mar 27, 2024

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Mar 27, 2024
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Let's merge it and see how things go on main 🙂

@kbrandwijk kbrandwijk merged commit a7165e1 into main Mar 27, 2024
10 checks passed
@kbrandwijk kbrandwijk deleted the kbrandwijk/eng-11815-action-in-expoexpo-requires-upgrading-to-actioncachev4 branch March 27, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants