Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(babel): add hermes tests for language features #27900

Merged
merged 7 commits into from Mar 28, 2024

Conversation

EvanBacon
Copy link
Contributor

Why

  • Inspired by chore(babel): drop @babel/plugin-transform-destructuring plugin #27885
  • Even though we have tests which catch a wide range of missing language features, it would be nice to have the tests fail faster and in isolation from a native build. Right now, they only run after a full native build has completed, which could lead to instances where the native build fails and we think it's fine to land anyways.

How

  • Add Hermes compilation to the babel jest tests and a number of language.

Test Plan

  • There's a chance this PR doesn't work in CI.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 27, 2024
EvanBacon and others added 3 commits March 27, 2024 13:42
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 27, 2024
@EvanBacon EvanBacon merged commit ae0e0ef into main Mar 28, 2024
8 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/babel/hermes-tests branch March 28, 2024 01:18
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants