[go] Update incompatible version screen with links to expo.dev/go
#27918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behenate
requested review from
brentvatne,
tsapeta,
lukmccall and
amandeepmittal
tsapeta
approved these changes
Mar 28, 2024
brentvatne
requested review from
kbrandwijk and
kadikraman
and removed request for
amandeepmittal
|
nice work! what do you think about this for iOS? my main motivation here was to provide the least amount of text possible, without sacrificing clarity. i also wanted to make the follow up actions extremely clear by putting them beside each other on the bottom, without any other text 
(I didn't mock this up for Android, let me know if that's needed - we should follow the same pattern) |
|
another thought - should we remove the "Try again" button here on this specific error screen? it really catches the eye and it's not very useful. |
|
Updated version:
|
tsapeta
reviewed
Apr 3, 2024
apps/expo-go/ios/Exponent/Kernel/AppLoader/CachedResource/EXManifestResource.m
Outdated
Show resolved
Hide resolved
…when it doesn't make sense.
behenate
force-pushed
the
@behenate/update-sdk-version-screen
branch
from
4c3e348
to
e058cd6
Compare
brentvatne
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
- How to Fix This Error -> How to fix this error
- add a bit less spacing under the "How to fix this error" header so it feels grouped with the text below it. maybe no extra spacing, just a normal amount of line spacing that we would use if it was part of the same paragraph
|
|
@brentvatne Hopefully the final edit 😅:
|
|
looks great! thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to link people to
https://expo.dev/gowhen they launch an incompatible project in Expo Go so it's easier for them to install a compatible Expo Go app.ENG-11732
How
Edited the existing messages to include installation links. Depending if running on a iOS device or in a simulator the behaviour is slightly different.
Also updated the code to work correctly when only one SDK version is available, on iOS added a more universal link parser that changes any combination of
[link](description)into a hyperlink instead.Test Plan
Tested in Expo Go on a physical Android device, emulator, physical iOS device and iOS emulator