Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] Update @react-native-async-storage/async-storage to 1.23.1 #28154

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

behenate
Copy link
Member

@behenate behenate commented Apr 11, 2024

Why

Updates react-native-async-storage to 1.23.1

For now it keeps it as a vendored module, because there are some patch files that should be applied only to ExpoGo version.

How

Updated the patch files, then run:

et uvm -m @react-native-async-storage/async-storage -c v1.23.1

Test Plan

Tesed in Expo Go in NCL on iOS 17 and Android 14

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Apr 11, 2024
@behenate behenate marked this pull request as ready for review April 11, 2024 18:41
@behenate behenate requested a review from Kudo April 16, 2024 12:04
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think you should also run pod install in bare-expo – the Podfile.lock should change there as well

@expo-bot
Copy link
Collaborator

The Pull Request introduced fingerprint changes against the base commit: ab7aaf6

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "ios",
    "reasons": [
      "bareNativeDir"
    ],
    "hash": "83135a6d03b514b124c599b6a2a6cf39b0b178bc"
  }
]

Generated by PR labeler 🤖

@behenate behenate merged commit 4e6c0a8 into main Apr 18, 2024
23 checks passed
@behenate behenate deleted the @behenate/sdk51/update-async-storage branch April 18, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants