Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] enable bytecode vtab for sqlite #28281

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Apr 18, 2024

Why

enable the sqlite bytecode vtab feature for livestore integration

How

originally i was thinking to add the feature as a builtin to all expo-sqlite libs but the sqlite3.podspec is not published yet. let's add this for expo-go first. for people using development builds, they could use a config-plugin to enable the feature.

Test Plan

launch expo-go and call the function to check whether {"compile_options": "ENABLE_BYTECODE_VTAB"} is existed

async function loadBuildFlagsAsync() {
  const db = await SQLite.openDatabaseAsync('test.db');
  const result = await db.getAllAsync<any>('PRAGMA compile_options');
  console.log('SQLite compile options:', result);
}

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Apr 18, 2024
@Kudo Kudo marked this pull request as ready for review April 18, 2024 12:45
@Kudo Kudo requested a review from alanjhughes April 18, 2024 12:45
@Kudo Kudo merged commit 355469e into main Apr 18, 2024
18 checks passed
@Kudo Kudo deleted the @kudo/go-sqlite-bytecodevtab branch April 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants