-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sqlite] add builtin support to import existing db #28291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
The Pull Request introduced fingerprint changes against the base commit: d735716 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-sqlite/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "85d53956059caa15c534a2f97f9b994c430ade2b"
},
{
"type": "dir",
"filePath": "../../packages/expo-sqlite/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "d193a624d37fc296fb91375b3fb5257f7608a68d"
}
] Generated by PR labeler 🤖 |
Kudo
force-pushed
the
@kudo/sqlite/builtin-import-existing-db
branch
from
April 18, 2024 16:13
e0fdf0e
to
43f0a64
Compare
Kudo
requested review from
Simek,
amandeepmittal and
alanjhughes
as code owners
April 18, 2024 17:30
amandeepmittal
approved these changes
Apr 18, 2024
Kudo
force-pushed
the
@kudo/sqlite/builtin-import-existing-db
branch
from
April 19, 2024 16:55
43f0a64
to
ef6a6a0
Compare
Kudo
requested review from
tsapeta,
byCedric,
EvanBacon,
brentvatne,
ide,
aleqsio,
wschurman,
douglowder,
lukmccall,
marklawlor,
gabrieldonadel and
quinlanj
as code owners
April 19, 2024 16:55
Kudo
force-pushed
the
@kudo/sqlite/builtin-import-existing-db
branch
from
April 19, 2024 16:57
ef6a6a0
to
c72557e
Compare
Kudo
removed request for
brentvatne,
wschurman,
ide,
byCedric,
marklawlor,
aleqsio,
quinlanj,
douglowder,
lukmccall,
EvanBacon,
gabrieldonadel and
tsapeta
April 19, 2024 16:58
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Apr 19, 2024
alanjhughes
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: fingerprint changed
bot: passed checks
ExpoBot has nothing to complain about
published
Changes from the PR have been published to npm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
it's good to save the way to import existing db
close ENG-11804
How
asides from #28289 and #28290. this pr tries to add a
SQLiteProvider.assetSource
for the builtin support.Test Plan
since we don't have testing infra to test hook inside test-suite, i have to do it manually:
reload the app the result would keep the same.
after remove the
forceOverwrite: true
and reload a couple times, the result would keep growing.tested on android and ios bare-expo.
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).