[docs] Enhance doubletap gesture in tutorial #28296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FX-Wood
changed the title
amandeepmittal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The doubletap gesture in the StickerSmash repository felt incomplete. After the first doubletap results in a 2x increase in size, subsequent doubletaps had no effect.
How
This change makes it so that doubletap gestures on 'stickers' alternately enlarges and shrinks them.
Test Plan
I tested this on the web build of my StickerSmash project.
Perhaps there could be some float equality issues on mobile, but I don't have a test setup for that.
Here's a minimal repo for anyone with a mobile test setup: https://github.com/FX-Wood/StickerSmash
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).