New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add Assets guide to Home #28331
base: main
Are you sure you want to change the base?
Conversation
📘 Your docs preview website is ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loved the assets docs and learned some things! Left some comments on things i would change. Thanks for writing this up.
Co-authored-by: Jon Samp <sampjon@gmail.com>
/* @hide ... */ /* @end */ | ||
|
||
function App() { | ||
return <Image source="example" />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to mention that this isn't particularly useful, but if some native api expects a resource name then this makes integration with that api easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
Follow up #28261
How
Update the outdated Assets guide
Add it to Home > Develop > User Interface
Add info on how to load local assets using
expo-assets
config pluginRemove duplicated info on optimizing images manually from Expo Updates Assets guide and update the section in Assets guide since this guide comes first in the hierarchy
Test Plan
Run docs locally and visit: http://localhost:3002/develop/user-interface/assets/, or see Preview: http://docs.expo.dev-pr-28331.s3-website-us-east-1.amazonaws.com/develop/user-interface/assets/
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).