[docs] Update using-sentry.mdx #28377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added conditional for enableNativeFramesTracking when in Expo Go
tsapeta
reviewed
Apr 23, 2024
docs/pages/guides/using-sentry.mdx
Outdated
| @@ -204,6 +205,7 @@ Sentry.init({ | |||
| new Sentry.ReactNativeTracing({ | |||
| // Pass instrumentation to be used as `routingInstrumentation` | |||
| routingInstrumentation, | |||
| enableNativeFramesTracking: Constants.appOwnership !== 'expo', // Only in native builds, not in Expo Go. | |||
There was a problem hiding this comment.
We'll be deprecating the appOwnership. It's better to use isRunningInExpoGo function from the expo package 馃槈
brentvatne
requested changes
Apr 23, 2024
Co-authored-by: Brent Vatne <brentvatne@gmail.com>
Co-authored-by: Brent Vatne <brentvatne@gmail.com>
amandeepmittal
changed the title
amandeepmittal
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Thanks for adding this @angelxmoreno!
Welcome to the Expo community and congratulations on your first contribution 馃帀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added conditional for enableNativeFramesTracking when in Expo Go
Why
Cause noobs like myself blindly copy-paste Expo's docs and if the examples provided in the docs do not work, we give up.
How
I cross referenced the instructions given by the Expo docs with the ones given by Sentry:
https://docs.sentry.io/platforms/react-native/performance/instrumentation/expo-router/
Test Plan
Error while fetching native frames: SentryError: Native is disabledexceptionChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).this is s doc change not a code change 馃し