New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] add reloadAppAsync support #28400
Conversation
The Pull Request introduced fingerprint changes against the base commit: 260acec Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-modules-core/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "c01acc6136594938e1d732c88168a962fed8631e"
},
{
"type": "dir",
"filePath": "../../packages/expo/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "69f961fbf9ccaff3305390a8b0e75940e97abede"
}
] Generated by PR labeler 🤖 |
9fe1122
to
c9760d4
Compare
c9760d4
to
1b4027d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the app has installed a new update, will this new reloadAppAsync()
method apply it? I anticipate two questions people will have are: why are there two reload methods and which one should I use?
no. |
I think the names are clear but also think it would be helpful in the docs for each function to explain how it is different than the other function. |
tried to update here. please help to review if the description is clear
|
Co-authored-by: James Ide <ide@users.noreply.github.com>
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
i was waiting for 0.74.1 for the changes from core and not using the reflection on android. since we may like to submit expo-go beforehand, i'm going to merge this first. later when we upgrade 0.74.1, i will remove the reflection. |
Why
close ENG-11482
How
introduce
reloadAppAsync()
from theexpo
packagesome reflection code could be removed after facebook/react-native#44223 landed
Test Plan
add NCL
ExpoCoreModule
to test the reload functionChecklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).