[video] Fix issues with the event system #28426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes a few issues I encountered with the
expo-video
event system.How
VolumeEvent
on android usedmuted
instead ofisMuted
property nameVideoPlayer's AVPlayer has been initialized with a AVPlayerItem instead of a VideoPlayerItem
was thrown when it wasn't necessaryAppContext
is initialised as the video is loaded early. This would lead to warnings. For now the player won't send events whenAppContext
is not present. In the future we should consider a more robust solution.Test Plan
Tested in BareExpo on Android 14 emulatore and iOS 17 device.