Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-expo): support using github.com/ URLs without protocol #28435

Merged
merged 2 commits into from Apr 29, 2024

Conversation

EvanBacon
Copy link
Contributor

Why

  • make the github template option a bit more resilient.
  • this PR also improves the error messages so you never see a "Only GitHub repositories are supported." when you provide a github URL.

Test Plan

  • This works cead -t github.com/evanbacon/apr24-template --no-install
  • This throws a reasonable error: cead -t github.com/evanbacon/test-missing-repo --no-install

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 24, 2024
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 24, 2024
@EvanBacon EvanBacon merged commit b4279ac into main Apr 29, 2024
21 of 22 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/create-expo-app/update-github-utilities branch April 29, 2024 16:29
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants