Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera] Support scanning barcode from URL #28445

Merged
merged 4 commits into from Apr 27, 2024

Conversation

alanjhughes
Copy link
Collaborator

@alanjhughes alanjhughes commented Apr 25, 2024

Why

Now that expo-barcode-scanner is deprecated, users have been asking for a replacement for BarcodeScanner.scanFromURLAsync. This PR adds that feature to camera.

How

Added Camera.scanFromURLAsync

Test Plan

Added a new screen to NCL to test

iOS Android
Simulator Screenshot - iPhone 15 Pro - 2024-04-25 at 09 24 33 Screenshot_20240425-092454

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 25, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 25, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Apr 25, 2024

The Pull Request introduced fingerprint changes against the base commit: b92f823

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-camera/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "eae12ca618c9f0afc94f02ea5ce70706337f5f09"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-camera/ios",
    "reasons": [
      "expoAutolinkingIos"
    ],
    "hash": "dc0bfcd987fa60785614c4743cc9ce7f00d497e5"
  }
]

Generated by PR labeler 🤖

@alanjhughes alanjhughes marked this pull request as ready for review April 25, 2024 08:44
@alanjhughes alanjhughes merged commit 0a8c904 into main Apr 27, 2024
11 of 12 checks passed
@alanjhughes alanjhughes deleted the @alanhughes/camera/scan-from-url branch April 27, 2024 09:28
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants