[core] fix use_frameworks with new arch #28451
Merged
+9
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fix header not found issue when using frameworks on new architecture
fixes #28209
How
the header search path is from
EXJavaScriptRuntime.mm -> HermesExecutorFactory.h -> <jsinspector-modern/InspectorInterfaces.h>
. the correct import should be underlined "jsinspector_modern" in the import. the code is inside react-native core that we cannot touch.this pr tries to use the
add_dependency()
from react-native core that we specify extra ":framework_name".also cleanup some unused search paths that are added through
install_modules_dependencies()
.we also have to wait 0.74.1 for facebook/react-native#44252
Test Plan
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).