Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add back ASC Api Key instructions for eas build CI #28465

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

quinlanj
Copy link
Member

Why

Add back the ASC Api Key instructions that was reverted in b058eea now that we've fixed it for provisioning profiles in expo/eas-cli#2347

How

Revert b058eea

Test Plan

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Apr 26, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Apr 26, 2024

📘 Your docs preview website is ready!

Copy link
Member

@amandeepmittal amandeepmittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

Left some minor suggestions.

docs/pages/build/building-on-ci.mdx Outdated Show resolved Hide resolved
docs/pages/build/building-on-ci.mdx Outdated Show resolved Hide resolved
docs/pages/build/building-on-ci.mdx Outdated Show resolved Hide resolved
quinlanj and others added 3 commits April 26, 2024 08:46
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants