[dev-client] Add missing header for JSC #28492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
alanjhughes
requested review from
lukmccall,
douglowder and
gabrieldonadel
as code owners
|
The Pull Request introduced fingerprint changes against the base commit: 0a8c904 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-dev-menu",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "ac91f3360a03117141bd561e6fbedd00ed71fb3f"
}
]Generated by PR labeler 🤖 |
alanjhughes
changed the title
lukmccall
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #28487
How
Not explicitly including the header for
JSIExecutorwill cause a build error when usingJSC. This is because whenHermesExecutorFactory.his excluded, the header is no longer included.Test Plan
Tested in bare expo with
hermesandjsc.