Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[updates] fix e2e errors on ios #28611

Merged
merged 3 commits into from
May 3, 2024
Merged

[updates] fix e2e errors on ios #28611

merged 3 commits into from
May 3, 2024

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented May 3, 2024

Why

fix https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/b9722d1c-b4d6-4d0a-aaaa-09e519875b9c

How

Test Plan

  • updates e2e should pass on ios
  • no strange Error: Cannot find module 'expo-dev-client/package.json' from updates e2e

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 3, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 3, 2024
@Kudo Kudo marked this pull request as ready for review May 3, 2024 17:25
@Kudo Kudo merged commit ab69adb into main May 3, 2024
28 checks passed
@Kudo Kudo deleted the @kudo/fix-updates-e2e-ios branch May 3, 2024 17:48
@brentvatne brentvatne added the published Changes from the PR have been published to npm label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants