[av][android] Fix events not working #28716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behenate
force-pushed
the
@behenate/sdk51/fix-av-event-regression
branch
from
cbdaf93
to
e7be385
Compare
expo-bot
added
bot: passed checks
|
The Pull Request introduced fingerprint changes against the base commit: 3f2a537 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-av/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "a04b161e7d0d2710ba6f4692590a5997b1e5adae"
}
]Generated by PR labeler 🤖 |
lukmccall
approved these changes
May 9, 2024
packages/expo-av/android/src/main/java/expo/modules/av/AVManagerInterface.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR fixes a regression introduced in SDK 51, caused by the fact that events sent using the wrong event emitter are not accepted.
Fixes #28698
How
Used a solution similar to
ExpoBattery, where thesendEventfunction from the module is passed to the calling class instance. In this case I used additional wrapper interface, becauseAVModuleis written in kotlin andAVManageris in java.Test Plan
Tested in BareExpo in Android 14 emulator.