Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][contacts] Fixed missing fields #6444

Closed
wants to merge 1 commit into from

Conversation

abdelilah
Copy link

Fixed firstName, lastName, addresses and image when using presentFormAsync.

Why

#6401

How

The native android module has some missing pieces in order to show the information needed. This PR introduces a few lines to address the issue.

Test Plan

Tested by using the native module in a simple app that presents the "add contact" form:

let result = await ImagePicker.launchImageLibraryAsync({
  mediaTypes: ImagePicker.MediaTypeOptions.All,
  allowsEditing: false,
  quality: 1,
});

Contacts.presentFormAsync(null, {
  [Contacts.Fields.FirstName]: "Jane",
  [Contacts.Fields.LastName]: "Doe",
  [Contacts.Fields.Company]: "Doe Inc",
  [Contacts.Fields.Addresses]: [
    {
      label: "home",
      street: "123 Wall street",
      city: "Paris",
      country: "France",
    },
  ],
  image: result,
});

@lukmccall
Copy link
Contributor

Hi @abdelilah, I've checked what was fixed in SDK 35 and what wasn't.

I decided to open a new pull request, cause some of your fixes are outdated. Moreover, firstName and lastName should be saved differently. But, I've added a link to your GitHub account into changelog entry.

I'm closing this PR in favour of #7285.

@lukmccall lukmccall closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants