Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android][web-browser] Fix WebBrowser sending 'dismiss' before opening #6743

Merged
merged 7 commits into from Apr 16, 2020
Merged

[android][web-browser] Fix WebBrowser sending 'dismiss' before opening #6743

merged 7 commits into from Apr 16, 2020

Commits on Mar 22, 2020

  1. [android][web-browser] Fix WebBrowser sending 'dismiss' before opening 

    Fixes expo#6679

TL;DR
A wrong usage of AppState causes WebBrowser to resolve with
`{ type: 'dismiss' }` before opening the view.

This is related to AppState being not initialised yet,
triggering a change before the user leaves the app view
to focus on the browser view.
    @LucaColonnello
    LucaColonnello committed Mar 22, 2020
    Copy the full SHA
    1e20f7c View commit details
    Browse the repository at this point in the history

  2. Build packages

    @LucaColonnello
    LucaColonnello committed Mar 22, 2020
    Copy the full SHA
    cb5335f View commit details
    Browse the repository at this point in the history

  3. Updated CHANGELOG

    @LucaColonnello
    LucaColonnello committed Mar 22, 2020
    Copy the full SHA
    3eafc3d View commit details
    Browse the repository at this point in the history

  4. Store only if AppState is available instead of every state change

    @LucaColonnello
    LucaColonnello committed Mar 22, 2020
    Copy the full SHA
    e8190f1 View commit details
    Browse the repository at this point in the history

  5. Clean yarn.lock

    @LucaColonnello
    LucaColonnello committed Mar 22, 2020
    Copy the full SHA
    04133af View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Update packages/expo-web-browser/CHANGELOG.md 

    Co-Authored-By: Łukasz Kosmaty <lukasz.kosmaty@student.uj.edu.pl>
    @LucaColonnello @lukmccall
    LucaColonnello and lukmccall committed Mar 23, 2020
    Copy the full SHA
    e8d13d4 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. Merge branch 'master' into @LucaColonnello/fix-web-browser-app-state-… 

    …init
    @brentvatne
    brentvatne committed Apr 16, 2020
    Copy the full SHA
    43b9d3d View commit details
    Browse the repository at this point in the history