Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[face-detector] Make Firebase pods version customisable, so it can be used with bare projects #7141

Merged
merged 3 commits into from May 14, 2020

Commits on May 14, 2020

  1. [face-detector] Make firebase pod version overridable

    This makes the firebase pod version overridable so that this package can be used in bare projects, together with other firebase packages. When Firebase versions differ accross multiple packages, pod install will fail. This follows the `$FirebaseSDKVersion` constants also used by react-native-firebase to maximize interop and make it easier for users to configure.
    
    [face-detector] Remove explicit FirebaseMLVision dependencies
    
    [face-detector] Update changelog
    
    Update packages/expo-face-detector/CHANGELOG.md
    
    Co-authored-by: Stanisław Chmiela <sjchmiela@users.noreply.github.com>
    IjzerenHein and sjchmiela committed May 14, 2020
    Copy the full SHA
    795d8d3 View commit details
    Browse the repository at this point in the history
  2. [ios] Pod install

    IjzerenHein committed May 14, 2020
    Copy the full SHA
    61f169a View commit details
    Browse the repository at this point in the history
  3. Update packages/expo-face-detector/CHANGELOG.md

    Co-authored-by: Stanisław Chmiela <sjchmiela@users.noreply.github.com>
    IjzerenHein and sjchmiela committed May 14, 2020
    Copy the full SHA
    5013930 View commit details
    Browse the repository at this point in the history