Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[battery] Remove deprecated isSupported #7206

Merged
merged 3 commits into from May 18, 2020
Merged

Conversation

bbarthec
Copy link
Contributor

@bbarthec bbarthec commented Feb 27, 2020

Why/How

Fixes #5584
Our SDK36 docs does not state anything about this deprecation anymore so I've removed it.
Additionally I've scoped Battery tests under one Battery section.

Test Plan

test-suite > Battery tests

Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add changelog entry (SDK38) and it's good to go 👍

Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick! Before you'll need to add these changes to an SDK39 changelog!

(well, actually you'll make them in the expo-battery's CHANGELOG, but you know)

@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@bbarthec bbarthec merged commit d26b3c7 into master May 18, 2020
@bbarthec bbarthec deleted the @bbarthec/battery-changes branch May 18, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[expo-battery] ios isSupported should return false in a simulator
3 participants