Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-permissions][android] Fix brightness permission #7276

Merged
merged 2 commits into from Mar 9, 2020
Merged

[expo-permissions][android] Fix brightness permission #7276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d042e5
[expo-permissions][android] Fix brightness permission
lukmccall Mar 4, 2020
99bde55
[expo-permissions] Update changelog.md
lukmccall Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -12,6 +12,8 @@ This is the log of notable changes to the Expo client that are developer-facing.

### 🐛 Bug fixes

- Fixed `Brightness.requestPermissionsAsync` throwing `permission cannot be null or empty` error on Android. ([#7276](https://github.com/expo/expo/pull/7276) by [@lukmccall](https://github.com/lukmccall))

## 37.0.0

### 📚 3rd party library updates
Expand Down
9 changes: 7 additions & 2 deletions ...ges/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsService.kt
View file
Open in desktop
Expand Up @@ -287,8 +287,13 @@ open class PermissionsService(val context: Context) : InternalModule, Permission
mAskAsyncListener = null
mAskAsyncRequestedPermissions = null

// invoke actual asking for permissions
askForManifestPermissions(askAsyncRequestedPermissions, askAsyncListener)
if (askAsyncRequestedPermissions.isNotEmpty()) {
// invoke actual asking for permissions
askForManifestPermissions(askAsyncRequestedPermissions, askAsyncListener)
} else {
// user asked only for Manifest.permission.WRITE_SETTINGS
askAsyncListener.onResult(mutableMapOf())
}
}

override fun onHostPause() = Unit
Expand Down