Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[file system][ios] Add multipart upload #7403

Merged

Conversation

lukmccall
Copy link
Contributor

Why

Part of #5841.

How

  • add multipart upload on iOS

Test Plan

Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs and changelog entry 😉

packages/expo-file-system/ios/EXFileSystem/EXFileSystem.m Outdated Show resolved Hide resolved
packages/expo-file-system/ios/EXFileSystem/EXFileSystem.m Outdated Show resolved Hide resolved
@lukmccall lukmccall requested a review from tsapeta March 23, 2020 11:32
@lukmccall lukmccall force-pushed the @lukmccall/expo-file-system-upload-android branch from 704b672 to ab938ce Compare March 24, 2020 13:58
@lukmccall lukmccall force-pushed the @lukmccall/expo-file-system-add-multipart-upload-ios branch 3 times, most recently from 23c07ef to 26d7cb6 Compare March 24, 2020 14:22
@lukmccall lukmccall requested a review from bbarthec March 24, 2020 14:24
Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 But one little thing 😉

packages/expo-file-system/ios/EXFileSystem/EXFileSystem.m Outdated Show resolved Hide resolved
@lukmccall lukmccall force-pushed the @lukmccall/expo-file-system-upload-android branch from ab938ce to de28ba9 Compare April 27, 2020 15:41
@lukmccall lukmccall changed the base branch from @lukmccall/expo-file-system-upload-android to master April 27, 2020 15:43
@lukmccall lukmccall force-pushed the @lukmccall/expo-file-system-add-multipart-upload-ios branch from 26d7cb6 to 1accf78 Compare April 28, 2020 12:13
@lukmccall lukmccall requested a review from bbarthec April 28, 2020 12:13
@github-actions
Copy link
Contributor

Native Component List for this branch is ready



Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it LGTM 😉 💯 Good job. Left some minor comments.

packages/expo-file-system/ios/EXFileSystem/EXFileSystem.m Outdated Show resolved Hide resolved
packages/expo-file-system/ios/EXFileSystem/EXFileSystem.m Outdated Show resolved Hide resolved
@lukmccall lukmccall force-pushed the @lukmccall/expo-file-system-add-multipart-upload-ios branch from d7455dd to 177e89a Compare April 29, 2020 08:49
@lukmccall lukmccall force-pushed the @lukmccall/expo-file-system-add-multipart-upload-ios branch from 177e89a to 342756e Compare April 29, 2020 08:56
@lukmccall lukmccall merged commit 37630a9 into master Apr 29, 2020
@tsapeta tsapeta deleted the @lukmccall/expo-file-system-add-multipart-upload-ios branch February 13, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Look into implementing Background Upload
3 participants