Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace AsyncStorage with community package #7566

Closed
wants to merge 2 commits into from

Conversation

jaulz
Copy link
Contributor

@jaulz jaulz commented Apr 1, 2020

Why

AsyncStorage is deprecated as you can see here: https://reactnative.dev/docs/asyncstorage

How

All AsyncStorage occurrences should be replaced with: https://github.com/react-native-community/async-storage

For web support I think we need to wait for react-native-async-storage/async-storage#317 on the legacy branch.

Test Plan

n/a

@jaulz jaulz requested review from ide and tsapeta as code owners April 1, 2020 07:08
@jaulz jaulz changed the title [WIP] fix: replace AsyncStorage with community package fix: replace AsyncStorage with community package Apr 1, 2020
@jaulz
Copy link
Contributor Author

jaulz commented Apr 1, 2020

I hope I found all the spots 😊

@tsapeta
Copy link
Member

tsapeta commented Apr 9, 2020

Hey @jaulz, thanks for this PR!
Unfortunately it's not enough that needs to be done in order to add support for any 3rd-party library. We also need to add its native code to our codebase so it gets versioned correctly for every SDK. I'll come back to this PR and merge it when the time comes 🙂

@superyarik
Copy link
Contributor

looks like react-native-async-storage/async-storage#317 is merged

@sjchmiela
Copy link
Contributor

Superseded by #8315.

@sjchmiela sjchmiela closed this May 22, 2020
@jaulz jaulz deleted the patch-5 branch May 25, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants