[firebase-analytics] Add DebugView support on Expo client #7796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IjzerenHein
force-pushed
the
@hein/expo-firebase/analytics-web-debugview
branch
from
e6f9385
to
09b0d08
Compare
Fixes the timestamps (deltas) in the send events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR adds support for using the
DebugViewmode in Google Analytics. This option is only supported on the standard Expo client which uses the pure JS implementation. All other environments are required to use the platform specific way of enabling debug mode.How
debugModeoption. Additionally a method calledsetDebugModeEnabled()has been added to enable/disable the debug-mode. Any events sent afterwards will be tracked in the DebugView console.Test Plan
expo-firebase-demodemo app (bare)setDebugModeEnabled()throws on native iOSDebug events recorded with the pure JS implementation