Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] update base64 decoding options #7841

Merged
merged 20 commits into from Apr 16, 2020
Merged

[android] update base64 decoding options #7841

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2f2a29c
[android] [camera] use .NO_WRAP to encode base64 output
Apr 14, 2020
e22c37d
[android] [image-manipulator] use .NO_WRAP to encode base64 output
Apr 14, 2020
e13f0eb
[android] [image-picker] use .NO_WRAP to encode base64 output
Apr 14, 2020
81db63c
[android] [print] use .NO_WRAP to encode base64 output
Apr 14, 2020
9ab00d8
[android] [secure-store] use .NO_WRAP to encode base64 output
Apr 14, 2020
fc17b04
[android] [camera] update change log to android base64 output
Apr 14, 2020
62fd230
[android] [image-manipulator] update change log to android base64 output
Apr 14, 2020
f876296
[android] [image-picker] update change log to android base64 output
Apr 14, 2020
d53810a
[android] [print] update change log to android base64 output
Apr 14, 2020
c087305
[android] [secure-store] update change log to android base64 output
Apr 14, 2020
b512a4a
[android] [image-manipulator] update base64 test
Apr 14, 2020
3001ba8
[android] [image-picker] update base64 test
Apr 14, 2020
aa0dbb1
[android] [camera] update base64 test
Apr 14, 2020
b1d0db6
Update apps/test-suite/tests/Camera.js
jarvisluong Apr 15, 2020
77d84b1
Update packages/expo-image-manipulator/CHANGELOG.md
jarvisluong Apr 15, 2020
7d6aaea
Update packages/expo-secure-store/CHANGELOG.md
jarvisluong Apr 15, 2020
bc0fe1e
Update packages/expo-camera/CHANGELOG.md
jarvisluong Apr 15, 2020
6bc8610
Update packages/expo-image-picker/CHANGELOG.md
jarvisluong Apr 15, 2020
a82d75a
[android] [camera] update description base64 test
Apr 15, 2020
b279e3c
Update packages/expo-print/CHANGELOG.md
jarvisluong Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/test-suite/tests/Camera.js
View file
Open in desktop
Expand Up @@ -95,8 +95,14 @@ export async function test(t, { setPortalChild, cleanupPortal }) {
});

t.it(
'returns Base64 only if requested, and base64 result does not contain newline character',
'this long description is forcing us to move testing method signature to the next line, but let's keep method body distinguishable by keeping indentation anyway',
async () => {
await mountAndWaitFor(<Camera ref={refSetter} style={style} />);
let picture = await instance.takePictureAsync({ base64: false });
t.expect(picture).toBeDefined();
...
}
)
jarvisluong marked this conversation as resolved.
Show resolved Hide resolved
await mountAndWaitFor(<Camera ref={refSetter} style={style} />);
let picture = await instance.takePictureAsync({ base64: false });
t.expect(picture).toBeDefined();
Expand Down