Fix uuid import syntax to use mandatory module syntax #8114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ide
changed the title
ide
requested changes
May 4, 2020
There was a problem hiding this comment.
Please rebuild the JS and add it to your commit: https://github.com/expo/expo/blob/master/CONTRIBUTING.md#-before-submitting
|
I foolishly didn't read the guidelines. Read then just now and:
If I missed anything let me know. |
bbarthec
reviewed
May 5, 2020
Co-authored-by: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
While
uuid@6prefers named importsuuid@8requires it. Using this import gets rid of theDeep requiring like const uuidv4 = require('uuid/v4'); is deprecated as of uuid@7.x.message in v7 and makes the constants package compatible with uuid v8.xHow
Simple import syntax fix.
Test Plan
Run any web project with constants.