Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-local-authentication] Add support for promptMessage, cancelLabel and disableDeviceFallback on Android #8219

Merged
merged 10 commits into from May 18, 2020
Merged

[expo-local-authentication] Add support for promptMessage, cancelLabel and disableDeviceFallback on Android #8219

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1cb7e4a
[ANDROID] Add local authentication options
diegolmello Apr 28, 2020
0f19a66
Unify tests
diegolmello May 8, 2020
3ed7424
Remove empty space
diegolmello May 15, 2020
a35311b
Use Map
diegolmello May 15, 2020
ef6e686
Change variables scope
diegolmello May 15, 2020
126b591
Fix lint
diegolmello May 18, 2020
0d4d203
Build
diegolmello May 18, 2020
626ca01
Unnecessary empty space removal
diegolmello May 18, 2020
b876411
Add changelog
diegolmello May 18, 2020
de58557
Update packages/expo-local-authentication/CHANGELOG.md
diegolmello May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/expo-local-authentication/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -6,4 +6,6 @@

### 🎉 New features

- Add `options` on Android. ([#8219](https://github.com/expo/expo/pull/8219) by [@diegolmello](https://github.com/diegolmello))
diegolmello marked this conversation as resolved.
Show resolved Hide resolved

### 🐛 Bug fixes
1 change: 1 addition & 0 deletions ...ion/android/src/main/java/expo/modules/localauthentication/LocalAuthenticationModule.java
View file
Open in desktop
Expand Up @@ -33,6 +33,7 @@ public class LocalAuthenticationModule extends ExportedModule {
private boolean mIsAuthenticating = false;
private ModuleRegistry mModuleRegistry;
private UIManager mUIManager;

private static final int AUTHENTICATION_TYPE_FINGERPRINT = 1;

private final BiometricPrompt.AuthenticationCallback mAuthenticationCallback =
Expand Down