Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[video][ios] Fix unable to call presentFullScreenPlayer twice #8343

Merged
merged 3 commits into from May 19, 2020
Merged

[video][ios] Fix unable to call presentFullScreenPlayer twice #8343

merged 3 commits into from May 19, 2020

Commits on May 18, 2020

  1. [expo-av][ios] Fix BOOL usage

    @IjzerenHein
    IjzerenHein committed May 18, 2020
    Copy the full SHA
    b263d45 View commit details
    Browse the repository at this point in the history

  2. [video][ios] Fix unable to call presentFullScreenPlayer twice 

    Fixes an issue when calling `presentFullScreenPlayer` more than once on iOS. This would result in the error “Fullscreen player is already being presented” when the `useNativeControls` prop also set on the `<Video>` component.

When useNativeControls is set, it re-creates the PlayerViewController every time the full-screen view-controller was closed. This caused the “videoBounds” key-value handler to be called which incorrectly assumed the regular ViewController was transitioning from full-screen to non full-screen. An additional check has been added to ensure this detection is not triggered when the full-screen viewcontroll is used.

When `useNativeControls` is set, calling `presentFullScreenPlayer` twice fails with
    @IjzerenHein
    IjzerenHein committed May 18, 2020
    Copy the full SHA
    19bfd92 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. [expo-av] Update changelog

    @IjzerenHein
    IjzerenHein committed May 19, 2020
    Copy the full SHA
    10b70fd View commit details
    Browse the repository at this point in the history