Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-file-system][docs] Add uploadAsync to docs file #8403

Merged
merged 2 commits into from May 22, 2020

Conversation

lukmccall
Copy link
Contributor

Why

I've forgotten to update docs when I've finished this task: #5841.

docs/pages/versions/unversioned/sdk/filesystem.md Outdated Show resolved Hide resolved
docs/pages/versions/unversioned/sdk/filesystem.md Outdated Show resolved Hide resolved

- **mimeType (_string_)** -- The MIME type of the provided file. If not provided, the module will try to guess it based on the extension.

- **parameters (_Record<string, string>_)** -- Additional HTTP parameters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By additional HTTP parameters you mean other form properties? Like… for fieldName: "image" under "image" there would be an image and here I could pass { name: "Stanley" } to have "Stanley" under "name"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly ;)

@lukmccall lukmccall requested a review from sjchmiela May 21, 2020 17:10
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@lukmccall lukmccall merged commit 4722d30 into master May 22, 2020
@lukmccall lukmccall deleted the @lukmccall/expo-file-system/update-docs branch May 22, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants